-
Notifications
You must be signed in to change notification settings - Fork 22
Migrate news section to blog (fixes #115) #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
allgandalf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raman976 can you confirm that you have included all the content from the news section into the blog one? have you left out any news?
|
yes I have included all the content from the news section into the blog. |
|
That's great!, Code also almost LGTM! i will trigger the workflow here :) and then we can discuss more |
|
@raman976 can you please add screenshot in the PR description of the changes you implemented, it helps anyone who will look into the PR in future |
|
hey @allgandalf, I have added screenshots showing the changes ,please tell if anything else needs to be done. |
|
@raman976 could you please resolve the merge conflicts? |
|
On my list for testing today, sorry for the delay 🙇 |
allgandalf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it LGTM! Apologies for the longgg delay here, just wanted to make sure we don't break anything :)
|
@raman976 can you please resolve merge conflicts ? |
Uh oh!
There was an error while loading. Please reload this page.